Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate test workflows #214

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Feb 19, 2024

This PR will migrate test workflow to GHA.

Before:

image

After:

image

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as draft February 19, 2024 10:10
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review February 19, 2024 10:26
@Xuanwo Xuanwo linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit ea747c9 into compio-rs:master Feb 19, 2024
27 checks passed
@Xuanwo Xuanwo deleted the workflow-migration branch February 19, 2024 12:33
runs-on: ${{ matrix.setup.os }}
strategy:
matrix:
toolchain: ["nightly", "beta"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since beta is the next stable predictably, perhaps we can verify beta directly and announce compio as always compatible with stable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At that time AFIT is not stablized. Now compio should be compatible with stable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. File #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port CI to Github Actions
3 participants